From 9d44f7ab04e6f6979e0eebc24f8fb439a23a3865 Mon Sep 17 00:00:00 2001 From: Sakarias Johansson Date: Thu, 12 Jan 2023 22:07:57 +0100 Subject: =?UTF-8?q?=F0=9F=A7=B9=20Minor=20cleanup?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Made the traits into supertraits so we don't have to mention Send and Sync everywhere. - Add methods for Vec3 that modifies the existing Vector. Can be used to make less copies. --- racer-tracer/src/material/lambertian.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'racer-tracer/src/material/lambertian.rs') diff --git a/racer-tracer/src/material/lambertian.rs b/racer-tracer/src/material/lambertian.rs index 8356685..d31e3e2 100644 --- a/racer-tracer/src/material/lambertian.rs +++ b/racer-tracer/src/material/lambertian.rs @@ -1,7 +1,7 @@ use crate::{ material::Material, ray::Ray, - vec3::{random_unit_vector, Color, Vec3}, + vec3::{random_unit_vector, Color}, }; pub struct Lambertian { @@ -17,7 +17,7 @@ impl Lambertian { impl Material for Lambertian { fn scatter( &self, - ray: &crate::ray::Ray, + _ray: &crate::ray::Ray, rec: &crate::geometry::HitRecord, ) -> Option<(Ray, Color)> { let mut scatter_direction = rec.normal + random_unit_vector(); @@ -27,7 +27,6 @@ impl Material for Lambertian { scatter_direction = rec.normal; } - let scattered = Ray::new(rec.point, scatter_direction); - Some((scattered, self.color)) + Some((Ray::new(rec.point, scatter_direction), self.color)) } } -- cgit v1.2.3